Closed HarikrishnanBalagopal closed 2 years ago
@rromannissen Thanks for taking a look at the PR.
Because of that, I see no point in applying changes to the application to work with PostgreSQL since that would break the proposed scenario.
That's fine, my intention is not to replace the database but to get it running locally. The current instructions in the README simply give an error when executed. They don't let you run it with or without Oracle.
Would it make sense to have 2 application.properties file similar to the Orders
service? One for local use with embedded H2 and another for Openshift use with Oracle?
update:
Seem the log
variable is created by the @Slf4j
annotation https://projectlombok.org/api/lombok/extern/slf4j/Slf4j.html
Example:
@Slf4j
public class LogExample {
}
will generate:
public class LogExample {
private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(LogExample.class);
}
Unrelated to this, but there seems to be more bugs:
https://github.com/konveyor/mig-demo-apps/blob/master/apps/e2e-demo/orders/src/main/java/io/konveyor/demo/orders/controller/OrderController.java#L37
The log
variable is not defined.
I think log
is supposed to be logger
similar to https://github.com/konveyor/mig-demo-apps/blob/master/apps/e2e-demo/customers-tomcat-k8s/src/main/java/io/konveyor/demo/ordermanagement/controller/CustomerController.java#L23
update: Actually the gateway service seems to be doing some processing to make it all work for the Frontend service, even going as far as to fetch customer data, hmm....
Another bug, the Order service returns a list instead of a page https://github.com/konveyor/mig-demo-apps/blob/master/apps/e2e-demo/orders/src/main/java/io/konveyor/demo/orders/controller/OrderController.java#L50-L51
It should return a page similar to the Customer service https://github.com/konveyor/mig-demo-apps/blob/master/apps/e2e-demo/customers-tomcat-k8s/src/main/java/io/konveyor/demo/ordermanagement/controller/CustomerController.java#L36-L37
This is not a bug in Orders
itself but during integration with the Frontend
service, it breaks the website.
The website expects a page not a list.
I will close this PR and open a new one later that makes the customers
service build locally without changing the database that is used. Thanks for taking a look at this PR.
The instructions on the README.md are not working: https://github.com/konveyor/mig-demo-apps/tree/7259959b620223494c84ac512760502be43b34af/apps/e2e-demo#running-locally
The sprint-boot maven plugin isn't present in the customers pom.xml and the profile
local
is also absent.I have created a new README for that service and slightly modified the persistence.properties to make the service runnable locally. Also created a maven wrapper for convenience and reproducibility.
Signed-off-by: Harikrishnan Balagopal harikrishmenon@gmail.com