konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:seedling: [backport release-0.4] Test image build when build related files change (#1907) #1914

Closed sjd78 closed 6 months ago

sjd78 commented 6 months ago

If the workflow is run from a PR, and the PR includes a change to the Dockerfile or package-lock.json, then run image builds for all of our target platforms.

The images are built but not pushed to any repository.

We want to be reasonably sure that any major build file changes will not cause the image-build-and-push on PR merge workflow to break. Doing the image build here should reveal most problems much earlier. For example, a npm version update in the build container could break github action nofiles or network access capabilities for the npm install.

See #1742, #1746, and #1781 for some other examples of when this check could have caught issues before a PR merge.

Supports: #1883 Backport-of: #1907