search

konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:sparkles: Update stakeholders table to use ActionsColumn #1923

Closed mguetta1 closed 2 months ago

mguetta1 commented 6 months ago

Part of https://github.com/konveyor/tackle2-ui/issues/1318

image

UI Tests PR: 1201

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.15%. Comparing base (b654645) to head (2d4b5c8). Report is 227 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1923 +/- ## ========================================== + Coverage 39.20% 42.15% +2.95% ========================================== Files 146 174 +28 Lines 4857 5577 +720 Branches 1164 1376 +212 ========================================== + Hits 1904 2351 +447 - Misses 2939 3210 +271 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1923/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1923/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.15% <ø> (+2.95%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1923/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sjd78 commented 3 months ago

Part of #1318?

mguetta1 commented 2 months ago

Part of #1318?

Yes

mguetta1 commented 2 months ago

Looks like a good change. @mguetta1 any reason it is still in draft?

I need to change this to use https://github.com/konveyor/tackle2-ui/blob/main/client/src/app/pages/controls/ControlTableActionButtons.tsx

sjd78 commented 2 months ago

@mguetta1 The PR change is causing e2e-ui-test fails:

The test is probably looking for a kebab menu action that doesn't exists or got moved to the edit pencil.

mguetta1 commented 2 months ago

@mguetta1 The PR change is causing e2e-ui-test fails:

The test is probably looking for a kebab menu action that doesn't exists or got moved to the edit pencil.

Correct, here is the related PR in tackle-ui-tests: https://github.com/konveyor/tackle-ui-tests/pull/1201 Please coordinate with @sshveta to merge the changes

sjd78 commented 2 months ago

Correct, here is the related PR in tackle-ui-tests: konveyor/tackle-ui-tests#1201 Please coordinate with @sshveta to merge the changes

We can tell CI to use that PR in the e2e testing: https://github.com/konveyor/ci?tab=readme-ov-file#referencing-specific-pull-requests-in-the-test-repositories

sjd78 commented 2 months ago

Note: Closed and reopened the PR to force all the check to run again with the update to the PR description to use a UI tests PR for e2e-ui testing.

sjd78 commented 2 months ago

@mguetta1 - One more UI test fix needed for: https://github.com/konveyor/tackle2-ui/actions/runs/10722793005/job/29734751734?pr=1923#step:12:1174

Looks like a migration wave test that is setting up stakeholders first.

mguetta1 commented 2 months ago

@mguetta1 - One more UI test fix needed for: https://github.com/konveyor/tackle2-ui/actions/runs/10722793005/job/29734751734?pr=1923#step:12:1174

Looks like a migration wave test that is setting up stakeholders first.

Thanks @sjd78. A fix was added.