konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:sparkles: Use hidden filter category for filtering on page load #1965

Closed rszwajko closed 5 months ago

rszwajko commented 5 months ago

Add hidden "id" filter category to application screen to ensure that active item is on page

Example usage: /applications?activeItem=6&filters={"id":["6"]}

rszwajko commented 5 months ago

Active item used together with ID filtering

Screenshot from 2024-06-18 17-03-28

ID filter category not listed in the toolbar

image

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.08%. Comparing base (b654645) to head (7550081). Report is 164 commits behind head on main.

Files Patch % Lines
...src/app/components/FilterToolbar/FilterToolbar.tsx 0.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1965 +/- ## ========================================== + Coverage 39.20% 42.08% +2.88% ========================================== Files 146 166 +20 Lines 4857 5334 +477 Branches 1164 1335 +171 ========================================== + Hits 1904 2245 +341 - Misses 2939 3073 +134 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1965/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.08% <0.00%> (+2.88%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rszwajko commented 5 months ago

Closing in favor of #1966