konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:bug: Add task detail links to tasks page #1980

Closed rszwajko closed 5 months ago

rszwajko commented 5 months ago
  1. extract base component to re-use for Analysis Details and Task Details
  2. add 2 new routes: a) /tasks/:taskId b) /tasks/:taskId/attachments/:attachmentId
  3. user can enter details screen by: a) task status name (link) b) "Task details" action (per row kebab actions)
  4. persist page state in session storage for Applications and Task Manager pages to fix problems with returning from task details page.

Resolves: #1975

rszwajko commented 5 months ago

Details screen available via link and action

image

Task details - log view

image

Task details - attachment view

image

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.23%. Comparing base (b654645) to head (4eff123). Report is 178 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1980 +/- ## ========================================== + Coverage 39.20% 42.23% +3.02% ========================================== Files 146 170 +24 Lines 4857 5451 +594 Branches 1164 1364 +200 ========================================== + Hits 1904 2302 +398 - Misses 2939 3032 +93 - Partials 14 117 +103 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1980/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.23% <100.00%> (+3.02%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1980/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rszwajko commented 5 months ago

@sjd78 Below the new wording. Note that Task 9 is last segment and is inactive (not a link) because it's the current page. Active links denote previous pages. At least this is my understanding of PF design guide .

image

On Analysis details screen situation is a bit different - we used "fake" application page (main table with details drawer opened). There "Analysis details" is the current page. image

rszwajko commented 5 months ago

@sjd78 one important fix was added - persisting page state in session storage:paging, sorting and filtering (Application page only). This should fix problems with returning back to main page from details pages.