search

konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:bug: Refactor task state to icon mapping #1984

Closed rszwajko closed 4 months ago

rszwajko commented 5 months ago

Follow the mapping used by the drawer with following changes:

  1. use PauseCircleIcon also for QuotaBlocked state
  2. use TaskIcon for Ready state (instead of CheckCircleIcon)
  3. use CheckCircleIcon for state Succeeded

Part-of: #1969

rszwajko commented 5 months ago

Screenshot from 2024-06-25 21-08-39 Screenshot from 2024-06-25 21-04-44

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.23%. Comparing base (b654645) to head (c29552e). Report is 179 commits behind head on main.

Files Patch % Lines
client/src/app/components/Icons/TaskStateIcon.tsx 27.27% 8 Missing :warning:
.../app/components/task-manager/TaskManagerDrawer.tsx 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1984 +/- ## ========================================== + Coverage 39.20% 42.23% +3.03% ========================================== Files 146 170 +24 Lines 4857 5443 +586 Branches 1164 1355 +191 ========================================== + Hits 1904 2299 +395 - Misses 2939 3128 +189 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1984/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.23% <43.75%> (+3.03%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/1984/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.