konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:bug: Filter credentials by createUser property #2006

Closed rszwajko closed 4 months ago

rszwajko commented 4 months ago

Drop conditional rendering as it clashes with column type definitions: the dynamic column is interpreted as optional property which is not allowed by the current typing in the table hooks.

Resolves: https://issues.redhat.com/browse/MTA-3143 Co-authored-by: Ian Bolton ibolton@redhat.com

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.19%. Comparing base (b654645) to head (f5c1e50). Report is 189 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2006 +/- ## ========================================== + Coverage 39.20% 42.19% +2.99% ========================================== Files 146 171 +25 Lines 4857 5479 +622 Branches 1164 1375 +211 ========================================== + Hits 1904 2312 +408 - Misses 2939 3050 +111 - Partials 14 117 +103 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2006/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2006/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.19% <ø> (+2.99%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2006/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rszwajko commented 4 months ago

Screenshot from 2024-07-11 17-22-55