konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:bug: Set filenames for task details downloads #2031

Closed sjd78 closed 4 months ago

sjd78 commented 4 months ago

Resolves: #2030

On the Analysis details / Task details page, the log viewer allows downloading of the file being displayed. Set a filename that matches the attachment name when doing the download.

File names used:

Due to the way the CodeEditor PF5 component implements the download action, only file extensions of known file types can be used. Any log or attachment files will have file extensions of .yaml or .json or .txt depending on the detected file type. File type detection is only using attachment name file extensions currently, and only differentiates between yaml and json with a default to plain text. For example, given an attachment name, the download file name will be:

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.15%. Comparing base (b654645) to head (5c9bced). Report is 202 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2031 +/- ## ========================================== + Coverage 39.20% 42.15% +2.95% ========================================== Files 146 171 +25 Lines 4857 5503 +646 Branches 1164 1353 +189 ========================================== + Hits 1904 2320 +416 - Misses 2939 3068 +129 - Partials 14 115 +101 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2031/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2031/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `42.15% <ø> (+2.95%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2031/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.