Closed rszwajko closed 3 months ago
Attention: Patch coverage is 17.24138%
with 48 lines
in your changes missing coverage. Please review.
Project coverage is 42.53%. Comparing base (
b654645
) to head (ff312e6
). Report is 213 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@sjd78 Changes:
@sjd78 @ibolton336 In the last commit I've managed to use our almighty table hooks to power the card view. This brings us closer to PF4 Card View pattern. Missing parts:
useSetting("ui.target.order")
Fun fact ....it's not the first time when I'm moving from card to table view :) Check out https://github.com/oVirt/ovirt-web-ui/pull/1600
The step loads correctly but lacks the features that depend on the optional queries:
After both queries are unblocked the screen loads the missing features.
https://github.com/user-attachments/assets/49671add-2386-410b-b06a-a4899fce903a
Without the targets the step has no data to work on - however the user still may skip the step and continue to the next one.
https://github.com/user-attachments/assets/e4e8d77d-787d-494a-b6b3-bb7a5b410201
@JustinXHale please take a look at screenshots above - basically we are moving towards standard Card View which means that we can add more filters or other features (sorting, paging, actions). We can also add a toggle that would allow users to switch to table or list view.
@sjd78 @rszwajko LGTM!
Before, in the Set Targets step, if the languages were not pre-selected automatically then no cards were visible. In order to see target cards user had to select at least one language. After this fix, all target cards will be visible.
Additional changes:
Resolves: https://github.com/konveyor/tackle2-ui/issues/2009 Resolves: https://issues.redhat.com/browse/MTA-3515