konveyor / tackle2-ui

Tackle (2nd generation) UI component.
Apache License 2.0
8 stars 43 forks source link

:sparkles: add ActionsColumn to Migration waves table #2109

Open sarinailinger opened 2 months ago

sarinailinger commented 2 months ago

the same actions that there is currently should stay but delete should be red & edit should be in another button(not in the list) implement it by ActionsColumn

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.98%. Comparing base (b654645) to head (49c7228). Report is 246 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2109 +/- ## ========================================== + Coverage 39.20% 41.98% +2.78% ========================================== Files 146 175 +29 Lines 4857 5630 +773 Branches 1164 1394 +230 ========================================== + Hits 1904 2364 +460 - Misses 2939 3250 +311 - Partials 14 16 +2 ``` | [Flag](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2109/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | Coverage Δ | | |---|---|---| | [client](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2109/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `41.98% <ø> (+2.78%)` | :arrow_up: | | [server](https://app.codecov.io/gh/konveyor/tackle2-ui/pull/2109/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=konveyor#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

rszwajko commented 2 weeks ago

@mguetta1 not that on small screens we suffer the same problems as with ControlTableActionButtons component but we won't benefit from https://github.com/konveyor/tackle2-ui/pull/2145 . Perhaps we need to folow-up and make ControlTableActionButtons more generic?

mguetta1 commented 2 weeks ago

@rszwajko noted. It is the same case also in application inventory page, which was fixed in https://github.com/konveyor/tackle2-ui/pull/2145