koobzaar / lol-skins

[⭐] A community-maintained repository featuring all 7,669 official League of Legends skins and chromas models as custom skins.
https://discord.gg/YpSNEBpm
GNU General Public License v3.0
146 stars 25 forks source link

Nightbringer yasuo sfx and animation #32

Closed aurisdaug closed 3 weeks ago

aurisdaug commented 1 month ago

there is some issues with the sfx of the skin, fixed the ult, because it played base vo when ulting and fixed the w sfx from base to the skin sfx, but the ult sfx and the animation is different https://youtu.be/4ibWAzx3TZs?si=iRQI5epUpakaEIT6&t=268 seen in this video there arent any shadows that appear when ulting and no skin sfx on ult, been trying but i cant seem to figure it out

(P.S. The skin is all good no major errors, just a minor animation and sfx issue, can't really notice it, but will be nice of you if fixed.)

edit: https://www.mediafire.com/file/omox7285ta352mg/nb_yas_test_V1.0_by_UNKNOWN.fantome/file this is the download for the ult VO fix and w base to skin sfx if needed

koobzaar commented 1 month ago

This probably happens because our current implementation doesn't have the animation/ folder in any of our skins.

We don't have plans to fix it in the near future. But we will definitely work on it.

I'll keep this issue open for future revisions.

Thanks!

nylish commented 3 weeks ago

@aurisdaug if you managed to solve the problem, open a PR with the .fantome skin! Thanks!