koobzaar / lol-skins

[⭐] A community-maintained repository featuring all 7,669 official League of Legends skins and chromas models as custom skins.
https://discord.gg/YpSNEBpm
GNU General Public License v3.0
146 stars 25 forks source link

Added 2 New Arcane Skins #70

Closed Emsumaa closed 2 days ago

Emsumaa commented 3 days ago

Arcane Brawler Vi Arcane Survivor Jayce

koobzaar commented 3 days ago

But we already have those skins - T1, Coven, Frightnight, Cafe Cuties and PsyOps. What exactly changed?

Also your PR says "Added 2 new arcane skins" but I cannot see any new Arcane skins in the changed files. And afaik is not possible to extract and use skins from PBE live (I might be wrong)

Emsumaa commented 2 days ago

These are the new arcane season 2 skins, they came out today. Oh and yeah the other t1 skins shouldnt be in there. That was a mistake. Only the Arcane skins.

Emsumaa commented 2 days ago

Wait I checked, and I have no idea why the arcane skins are not in there. I wanted to upload the other skins you currently see in there like a month ago but I didnt know how to. And today I tried it again and it seems that these skins are still in there... Idk sorry

Emsumaa commented 2 days ago

How tf do I delete my branch and make like a clean install? Or can I delete the repository from me with no problems?

koobzaar commented 2 days ago

Hello!

Git and GitHub can be a little frustrating sometimes.

It looks like the changes you made weren't uploaded because you likely forgot two important steps:

  1. Create a commit to save your changes
  2. Push the commit to the remote repository you forked.

Let me break this down in simple terms:

A "commit" is like taking a snapshot of your project at a specific moment. Think of it as saving your work, but in a way that keeps track of all the changes you've made. When you make changes to your files, you need to:

For people who aren't developers and find this technical process challenging, I recommend using GitHub Desktop. It makes version control much easier and more user-friendly. It provides a visual interface that simplifies the process of managing your code and tracking changes.

Regarding updating your repository, you can use the command git pull. This command brings the most recent changes from the main repository. However, since you have existing changes in your branch, you'll need to do a bit more:

If this sounds overwhelming, there are many beginner-friendly tutorials that can help you learn how to use GitHub Desktop and understand git in a simpler way.