search

kooloveme / thtmlviewer

Automatically exported from code.google.com/p/thtmlviewer
Other
0 stars 0 forks source link

Patch for CSS border-spacing #328

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Which steps will reproduce the problem?
1. use the attached test.html and load with various browsers

What is the expected output? 

CSS border-spacing should separate cells in a table by specified value

What do you see instead?

a default border-spacing provided in every table.

See the comparison screenshot between range of browsers.

Which version of the product are you using? Which compiler version are you
using? On which operating system?

Delphi 7/Delphi XE5

Please attach test html files and screenshots, if appropriate.

See attached

Please provide any additional information:

Patch provided that resolves issue. Feedback is appreciated if improvements can 
be made.

Original issue reported on code.google.com by ja...@momail.medical-objects.com.au on 3 Feb 2014 at 7:47

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks for this patch.

I'm gonna apply it ASAP.

Original comment by OrphanCat on 3 Feb 2014 at 5:25

GoogleCodeExporter commented 9 years ago 
I have merged this at my end but I'm not satisfied.  Border-spacing actually 
can take two parameters.  In that case, the first value is horizontal spacing.  
The second value is the vertical spacing.

See:
http://www.w3.org/TR/CSS2/tables.html#propdef-border-spacing

Original comment by jpmug...@suddenlink.net on 1 Jul 2014 at 12:08

GoogleCodeExporter commented 9 years ago 
I have gone ahead and did the coding for the border-spacing property that 
accepts two parameters (horizontal and vertical).  See:

https://github.com/JPeterMugaas/HtmlViewer/tree/HtmlViewer-11.4-to-11.5

I hope this is merged in soon.

Original comment by jpmug...@suddenlink.net on 2 Jul 2014 at 4:12

GoogleCodeExporter commented 9 years ago 
thanks for reviewing this patch and improving on it. I too hope that these 
improvements will be merged soon.

Original comment by ja...@momail.medical-objects.com.au on 2 Jul 2014 at 4:35

GoogleCodeExporter commented 9 years ago 
r475 applies patch and JPM's improvements.

Original comment by OrphanCat on 14 Jul 2014 at 8:47