search

korapp / plasma-nordvpn

Simple Plasma Applet for the official NordVPN linux client
GNU General Public License v3.0
19 stars 1 forks source link

Colors icon in dark theme incorrect #29

Closed jsaenzh01 closed 5 months ago

jsaenzh01 commented 5 months ago

Describe the bug In plasma 6, icon is showed dark, in a dark theme.

To Reproduce

  1. Install nordvpn
  2. Show a dark color

Expected behavior A expected a white icon in a dark color

Screenshots Captura de pantalla_20240303_050333

Desktop (please complete the following information):

Additional context Thanks for porting plasmoid so fast!

korapp commented 5 months ago

I've tested this on KDE Neon and the icon behaves correctly, so maybe it's a problem with the packages or the update process.

  1. Have you installed Plasma 6 yourself from a third party repository (OpenSUSE Argon seems to be based on Leap 15.4)?
  2. Is this a new installation or was it updated from Plasma 5?
    1. If the latter, did you use the plasmoid before?
jsaenzh01 commented 5 months ago

Hi, 1.- I installed Kde 6.0 from Opensuse repos: https://en.opensuse.org/SDB:KDE_repositories

`zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Qt5/openSUSE_Leap_$releasever' KDE-Qt5 zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Qt6/openSUSE_Leap_$releasever' KDE-Qt6 zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Frameworks/openSUSE_Leap_$releasever' KDE-Frameworks zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Frameworks5/openSUSE_Leap_$releasever' KDE-Frameworks5 zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Applications/KDE_Frameworks5_openSUSE_Leap_$releasever' KDE-Applications zypper ar -fp 75 'https://download.opensuse.org/repositories/KDE:/Extra/KDE_Applications_openSUSE_Leap_$releasever' KDE-Extra zypper -v dup --allow-vendor-change

TBD, not available just yet

zypper -v install pattern:kde_plasma6

`

It's not a new installation. I have used for a long time. I have used your plasmoid since one year ago. I had to uninstall old version in order to install version 1.0.

I also delete all config files related to plasma -> rm .config/plasma* .

I use breeze twilight theme (no dark). Maybe Its the difference. I have also reapplied the theme. Captura de pantalla_20240304_193715

Thanks for answering! and I'm sorry for my english! (it's not my first language)

korapp commented 5 months ago

I use breeze twilight theme (no dark). Maybe Its the difference. I have also reapplied the theme.

This is it! It looks like Plasma 6 sets the ColorScheme-Text from Application Style, which in the case of the Twilight theme results in a dark icon on a dark panel. I will dig deeper, but for now I see that Plasma itself has similar problems: Screenshot_20240305_221701 (plasmoidviewer)

jsaenzh01 commented 5 months ago

Hi, With your answer, I open a bug in Kde: https://bugs.kde.org/show_bug.cgi?id=482645

Some color icons (discover, for example) are correct now.

Maybe it helps...

korapp commented 5 months ago

Great! I recently received 6.0.2, but it does not fix the theming of the "external" icons. However, it seems that setting a complementary color set fixes the issue.