search

korcankaraokcu / PINCE

Reverse engineering tool for linux games
Other
2.13k stars 149 forks source link

Fixed `get_list()` to not show incompatible scan type options #260

Closed OpenNetSurfer closed 6 months ago

OpenNetSurfer commented 6 months ago
brkzlr commented 6 months ago

Apologies, I came back to this late because you force-pushed the last commit, keeping the commit message same so GitHub didn't tell me you changed anything. Just noticed it now when I manually checked your last commit from your fork.

I'll close this PR and fix the bug myself as you either keep ignoring what I'm asking you to do or not fully reading my review comments as you now removed CHANGED/UNCHANGED from STRING like I asked you too but you still didn't restore UNKNOWN for AOB like I asked and even removed it from STRING now, a valid scan type for both.

Sorry but doing constant back and forth for a very simple change request takes more time than actually doing it.

OpenNetSurfer commented 6 months ago

I am sorry, I couldn't understand well. Will not happen again