Added option to show the full stack from `Base Pointer` also

korcankaraokcu / PINCE

Reverse engineering tool for linux games

Other

2.07k stars 149 forks source link

Added option to show the full stack from `Base Pointer` also #263

Closed OpenNetSurfer closed 3 months ago

OpenNetSurfer commented 3 months ago

When viewing full stack in stack viewer and the process is stopped, Show from BP register or Show from SP register in context menu is shown.
Changed name sp_register to stack_register in def invoke(self, arg, from_tty): to appear more meaningful

OpenNetSurfer commented 3 months ago

Please note that this feature exist in cheat engine, so I have added it here too. It saves the hassle when machine instructions use the BP register also

korcankaraokcu commented 3 months ago

Works well. Just one more thing, you forgot to document the new parameter you've added in get_stack_info. Check other functions such as handle_signal within debugcore module to see examples of argument documentation. We've recently started to use type hints. It'd be great if you could also add a type hint to your parameter