search

kort / kort-home

The website of the Kort-App
http://kort.ch
3 stars 4 forks source link

Translated sites added #6

Closed rkrucker closed 10 years ago

rkrucker commented 10 years ago

Sites translated hardcoded after stefans requests

metaodi commented 10 years ago

I think the English version should be linked somewhere, not just be available as files => We need some kind of language switcher. And related: all English pages should link to the other English pages (e.g. developers_en.html should link to index_en.html not index.html).

rkrucker commented 10 years ago

will do so Am 06.12.2013 13:41, schrieb Stefan Oderbolz:

I think the English version should be linked somewhere, not just be available as files => We need some kind of language switcher. And related: all English pages should link to the other English pages (e.g. |developers_en.html| should link to |index_en.html| not |index.html|).

— Reply to this email directly or view it on GitHub https://github.com/kort/kort-home/pull/6#issuecomment-29987206.

rkrucker commented 10 years ago

Morning I got a quick question regarding the translation Would you prefer an automatic redirection based on the browsers settings or would you like some kind of field where the user can choose which language should be displayed? Am 06.12.2013 13:41, schrieb Stefan Oderbolz:

I think the English version should be linked somewhere, not just be available as files => We need some kind of language switcher. And related: all English pages should link to the other English pages (e.g. |developers_en.html| should link to |index_en.html| not |index.html|).

— Reply to this email directly or view it on GitHub https://github.com/kort/kort-home/pull/6#issuecomment-29987206.

metaodi commented 10 years ago

@rkrucker we use the automatic detection already in Kort, so this would be perfect. If the guess is wrong, the user should be allowed to change the language himself.

rkrucker commented 10 years ago

Are the changes made in the last commit(9.12.13) okay? I changed the doctype and added a little button to the topnavigation which takes you to the german/english version of the site you are looking at. Additionally, Stefan asked me to ask you if you can grant me access to uservoice, transifex and maybe additional parts. kind regards rafael

metaodi commented 10 years ago

Thank you very much for your pull request :+1: , I'll have a closer look at it tonight and give you feedback.

metaodi commented 10 years ago

I quickly checked out your changes locally. Currently the browsing of the page is strange: if I choose to browse the English page, I want the navigation to point to all the English pages, this is currently not the case. This is what I meant with "all English pages should link to the other English pages (e.g. developers_en.html should link to index_en.html not index.html)".

Do you know what I mean?

rkrucker commented 10 years ago

ah off course sorry, thats logical. I got stefans old instructions mixed up in it, sorry. I will make another commit today sometime before 7, (hopefully) including the final pages Am 10.12.2013 15:30, schrieb Stefan Oderbolz:

I quickly checked out your changes locally. Currently the browsing of the page is strange: if I choose to browse the English page, I want the navigation to point to all the English pages, this is currently not the case. This is what I meant with "all English pages should link to the other English pages (e.g. |developers_en.html| should link to |index_en.html| not |index.html|)".

Do you know what I mean?

— Reply to this email directly or view it on GitHub https://github.com/kort/kort-home/pull/6#issuecomment-30231220.

metaodi commented 10 years ago

Thanks a lot for your efforts! :+1: