korzio / djv

Dynamic JSON Schema Validator - Supports draft-04/06
https://www.npmjs.com/package/djv
MIT License
289 stars 31 forks source link

Sync Test suite with json-schema-benchmark #90

Open korzio opened 5 years ago

korzio commented 5 years ago
  1. Ensure test suite is equal to the one used inside the https://github.com/ebdrup/json-schema-benchmark/ repository . Currently https://github.com/json-schema-org/JSON-Schema-Test-Suite is a git dependency inside package.json for the djv project. Inside the https://github.com/ebdrup/json-schema-benchmark/ it is used in a different way - as a git sub module.
  1. Fix tests is some are failing
  2. Understand how the update of benchmark will happen, both in benchmark and djv repository. They should be synced
korzio commented 5 years ago

Dear @ebdrup

We see that in the json-schema-benchmark repository you use a git submodule for JSON-Schema-Test-Suite dependency. We see in the github a link to the commit with the SHA 86f965e53dda0b6c57e70ddd726243e1e061cf84 , but we cannot find any reference in the codebase about this specific commit. We also see that the latest "tagged" version of JSON-Schema-Test-Suite is https://github.com/json-schema-org/JSON-Schema-Test-Suite/commits/2.0.0 and for now djv is compliant with it. But we'd like to go further and adopt latest tests and start working on updated suites. So, our questions are:

I hope you can point us to the right direction, otherwise please let me know who else can help :) Thanks in advance

korzio commented 4 years ago

https://github.com/korzio/djv/pull/92

korzio commented 4 years ago