kotct / dot

A collaborative configuration for various tools.
MIT License
3 stars 2 forks source link

Add support for display-line-numbers-mode #120

Closed rye closed 6 years ago

rye commented 6 years ago

This PR moves linum-c to line-numbers-c to make it more general-purpose, and extracts existing logic into a helper function before adding another helper method.

The new functionality on 26.1 is to disable global-linum-mode (probably not necessary) before enabling global-display-line-numbers-mode. Then, hooks are added to turn off display-line-numbers-mode on a few modes that don't seem to like it, such as dired-mode, git-commit-mode, magit-derived modes, and package-menu-mode.

Open to further requests or stylistic feedback. Otherwise, I would say ToT is ready to use in production.

Resolves #98.

rye commented 6 years ago

Merging.