kothic / kothic-js

Kothic JS — a full-featured JavaScript map rendering engine using HTML5 Canvas
http://kothic.org
BSD 2-Clause "Simplified" License
451 stars 46 forks source link

Casing broken since the recent dashing changes #60

Open DerDakon opened 8 years ago

DerDakon commented 8 years ago

This is how OpenRailwayMap looks with the original rendering code: casing-old

This is how it looks now: casing-new

The casing is now either always on or always off as it looks to me. The change is the new dashing code from @braandl.

braandl commented 8 years ago

Hm, I use the new code in my Application, and I can not find any of that behavior so far. When does this happen? no-dashing-issues

DerDakon commented 8 years ago

It's this code.

braandl commented 8 years ago

Hm, when I define casing and dashing in the same selector, it works as intended, i think? Maybe you should define the dashes in "way|z9-[railway=razed].tracks", too?

I am not sure what the correct behavour is...

image

DerDakon commented 8 years ago

Your case looks correct.

DerDakon commented 8 years ago

Which version of Leaflet do you use? Which Browser?

braandl commented 8 years ago

Leaflet 0.7.7 and I did test it with Google Chrome, Firefox on Windows, Ubuntu , Opera on Windows and Mobile and Safari MacOsX 10.11 aswell as on iPhones with iOS 9.3 and on an iPad Air having no issues that I am aware of.

braandl commented 8 years ago

All the Browsers were always updated to the latest stable version.

DerDakon commented 8 years ago

We were still using Leaflet 0.6.2 back then, but meanwhile I upgraded. I'll test again.

DerDakon commented 8 years ago

abandoned

South of the bridge this is just one way, which in the middle stops showing any casing. I changed the base color to green just to make sure there are no other styles interfere with that.

Have you tried your code when the line crosses tile borders?

braandl commented 8 years ago

Yes, it works on my Installation that provides tiles for entire regions as gjson

braandl commented 8 years ago

multiple-tiles-casing

The only difference I can see so far, is that my leaflet configuration is using elements to render the tiles in, and openrailwaymap.org deliveres to me. But I guess you are rendering it on a canvas to?