search

kothic / kothic-js

Kothic JS — a full-featured JavaScript map rendering engine using HTML5 Canvas
http://kothic.org
BSD 2-Clause "Simplified" License
451 stars 46 forks source link

Added Leaflet 1.x compatiblity #70

Closed braandl closed 4 years ago

braandl commented 7 years ago

Added Leaflet 1.x compatiblity. Updated Debug / Demo Section. Updated Dependencies. Dropped Support for Leaflet 0.x.

nickw1 commented 5 years ago

Nice! Confirmed as working on Leaflet 1.4.0. Would be nice to remove the jQuery dependency in the current kothic-leaflet.js; looks like it's needed to load JSON-P.

braandl commented 5 years ago

@nickw1 I removed jQuery dependency from the Kothic Lib. I only kept it in the index.html for the debug messages.

nickw1 commented 4 years ago

@braandl @DerDakon would be great to see this in the main kothic repo. I'm happy to work on this with @DerDakon's change suggestions if necessary.

braandl commented 4 years ago

@nickw1 I did some more 'cosmetics' on this for you. I removed the script compat because I believe it is bad style and it is not needed anymore in modern webapps. Also the grunt option changes are nececssary to build with newer grunt versions. If you are dedicated to enhance this even more, you might think about switching to webpack or another modern javascript stack, other than the rather outdated grunt.

nickw1 commented 4 years ago

@braandl thanks - but just to clarify I am not the maintainer, that is @DerDakon. I am just a kothic user/very occasional contributor (have made 2 PRs recently) and was just making the comment as a Kothic user that it would be nice to see this in master. It's up to @DerDakon on whether it's good to merge now. Apologies for any confusion I may have caused!

DerDakon commented 4 years ago

I'm not really a maintainer, I just use to have commit access. One obvious thing is that this branch seems to need a rebase as it shows collisions on kothic.js.

Komzpa commented 4 years ago

To cause more confusion: I just came in here out of random reason, found an ongoing conversation and that there are lively PRs, and also that for some reason my notifications were switched off for this repo. To decrease bus factor, I've added @nickw1 to collaborators, as I know long time user of Kothic JS and thus a valuable stakeholder, you should be able to accept PRs too now.

nickw1 commented 4 years ago

@Komzpa many thanks for adding me as collaborator, @braandl I will check your PR, verify all is working and fix any conflicts.

nickw1 commented 4 years ago

@braandl to update you: have created a new branch leaflet1.0 in the main kothic repo and am merging your PR into that, so that any issues can be resolved before it goes in master.