search

kovshenin / surge

Surge is a very simple and fast page caching plugin for WordPress.
GNU General Public License v3.0
156 stars 11 forks source link

Error logs full of PHP Warnings for "no such file or directory" trying to unlink #42

Open MadtownLems opened 1 month ago

MadtownLems commented 1 month ago

I feel like these errors used to be occasional throughout our error log, but when I checked today - it was just absolutely loaded with them for tons of domains.

[09-Oct-2024 13:32:30 UTC] PHP WARNING: [unlink(/home/accountname/public_html/wp-content/cache/surge/ff/d811be4bfa6ef72b7f7b51533048f7ff.php): No such file or directory] in file /home/accountname/public_html/wp-content/plugins/surge/include/cron.php:81 at https://domain.com/wp-cron.php?doing_wp_cron=1728480748.5616080760955810546875 [09-Oct-2024 13:32:30 UTC] PHP WARNING: [unlink(/home/accountname/public_html/wp-content/cache/surge/ff/f047504dfed51d7d68ef7ebb5db38dff.php): No such file or directory] in file /home/accountname/public_html/wp-content/plugins/surge/include/cron.php:81 at https://domain.com/wp-cron.php?doing_wp_cron=1728480748.5616080760955810546875 [09-Oct-2024 13:32:30 UTC] PHP WARNING: [unlink(/home/accountname/public_html/wp-content/cache/surge/ff/f0645fb9a32d1c2f1f1da8f77a846dff.php): No such file or directory] in file /home/accountname/public_html/wp-content/plugins/surge/include/cron.php:81 at https://domain.com/wp-cron.php?doing_wp_cron=1728480748.5616080760955810546875 [09-Oct-2024 13:32:30 UTC] PHP WARNING: [unlink(/home/accountname/public_html/wp-content/cache/surge/ff/f1e56b89471a55e372e1508d5d6972ff.php): No such file or directory] in file /home/accountname/public_html/wp-content/plugins/surge/include/cron.php:81 at https://domain.com/wp-cron.php?doing_wp_cron=1728480748.5616080760955810546875 [09-Oct-2024 13:32:30 UTC] PHP WARNING: [unlink(/home/accountname/public_html/wp-content/cache/surge/ff/f38c44c998c159e871ad055f68fa0aff.php): No such file or directory] in file /home/accountname/public_html/wp-content/plugins/surge/include/cron.php:81 at https://domain.com/wp-cron.php?doing_wp_cron=1728480748.5616080760955810546875 [09-Oct-2024 13:32:30 UTC] PHP WARNING: [unlink(/home/accountname/public_html/wp-content/cache/surge/ff/f46518e2df28120b9c8ffe3d782b4cff.php): No such file or directory] in file /home/accountname/public_html/wp-content/plugins/surge/include/cron.php:81 at https://domain.com/wp-cron.php?doing_wp_cron=1728480748.5616080760955810546875 [09-Oct-2024 13:32:30 UTC] PHP WARNING: [unlink(/home/accountname/public_html/wp-content/cache/surge/ff/f79a41f23c205f2ad148e1f53b5b96ff.php): No such file or directory] in file /home/accountname/public_html/wp-content/plugins/surge/include/cron.php:81 at https://domain.com/wp-cron.php?doing_wp_cron=1728480748.5616080760955810546875 [09-Oct-2024 13:32:30 UTC] PHP WARNING: [unlink(/home/accountname/public_html/wp-content/cache/surge/ff/fbdc2db024d541c3d3d3fe4959562cff.php): No such file or directory] in file /home/accountname/public_html/wp-content/plugins/surge/include/cron.php:81 at https://domain.com/wp-cron.php?doing_wp_cron=1728480748.5616080760955810546875

kovshenin commented 1 month ago

Hmm, that's strange. We have a couple of checks to make sure the file exists before doing anything with it:

https://github.com/kovshenin/surge/blob/main/include/cron.php#L49-L57

Anything special about your setup?

MadtownLems commented 1 month ago

Anything special about your setup?

Nothing that I can really think of being incredibly relevant.

It's multisite, and a very old one that still uses ms-files.php and the /wp-content/blogs.dir/ directory. Pretty standard WHM/cPanel with Apache, PHP 8.1, Zend OpCache, etc It does have Shibboleth running for Single Sign On, but can't see how that would be relevant here.

We ARE running a custom surge-modifier plugin, but all it does is add a bunch of flush actions via the surge_flush_actions filter.

For reference, I just checked the most recent errors against the current files in /cache/surge/ and the ones it's saying "no such file or directory" for are not there. Of course I don't know if it was there before surge tried to remove it.

Quite odd indeed, given the checks you pointed at - but the errors are definitely still piling up 🤔

MadtownLems commented 1 month ago

Just noticed tons of this in the logs, too. Posting here in case it's related, but happy to open a new issue if you don't think it is:

[03-Oct-2024 14:44:19 UTC] PHP Warning: Undefined array key "path" in /home/accountname/public_html/wp-content/plugins/surge/include/common.php on line 83