search

kpn / kpn-style

Reusable (style) packages for anyone working on front-end for KPN.
https://style.kpn.com
MIT License
17 stars 3 forks source link

refactor(packages): kpn-style now lives in its own folder inside packages #3

Closed woile closed 4 years ago

woile commented 4 years ago

For planned integration with lerna.

from packages/** to packages/kpn-styles/**.

This would allow to eventually create more packages related to kpn-styles but having them published separatedly.

Example of other packages:

packages/
├── kpn-styles/
├── kpn-webcomponents/
├── kpn-react/
├── kpn-pollyfills/
└── create-kpn-app/

The user would have to install them by doing yarn add @kpn/create-kpn-app or yarn add @kpn/kpn-styles, etc. But for devs remains a monorepo.

benmb1984 commented 4 years ago

It is good to separate the folders so we are prepared for the future. The README file in the root is used in the portal as Quick start guide. We can have a more detailed README file in the packages folder. For me it is ok to merge this PR and then move content to other README files to improve our docs

coenkoopmans commented 4 years ago

Discussed with @Woile and the team and decided not to implement this yet pending research on the best way to structure the project. Will create an issue for this.