kra-mo / cartridges

A GTK4 + Libadwaita game launcher
GNU General Public License v3.0
628 stars 32 forks source link

Keyboard accelerators don't work on Linux #281

Closed largestgithubuseronearth closed 2 months ago

largestgithubuseronearth commented 2 months ago

Describe the bug The keyboard accelerators for menu actions can't be used on Linux because there is no Meta key. All accelerator hints show something like "Import Meta + I" but there's no key combination that can activate that on Linux. Clicking the button works fine so it's only the shortcut/accelerator that isn't functional.

Expected behavior The action accelerators would be functional and display the proper accelerator shortcut on all OS options that Cartridges supports.

Screenshots Screenshot from 2024-07-18 01-39-18

System (please complete the following information):

Additional context The issue likely stems from the create_actions method that was changed to accommodate MacOS (linked). Reverting this immediately resolves the issue for me when testing in Builder, but I wouldn't know how to make a solution for both Linux and MacOS.

https://github.com/kra-mo/cartridges/blame/7efa17915f75a5ac4b484ad3c46d443e8d62c345/cartridges/main.py#L402

kra-mo commented 2 months ago

The issue likely stems from the create_actions method that was changed to accommodate MacOS (linked). Reverting this immediately resolves the issue for me when testing in Builder, but I wouldn't know how to make a solution for both Linux and MacOS.

I just forgot to add the conditional logic per platform when testing 😅

largestgithubuseronearth commented 2 months ago

Tested it and it seems good! Thank you for the quick turn around :)