kraflab / dsda-doom

This is a successor of prboom+ with extra tooling for demo recording and playback, with a focus on speedrunning and quality of life.
341 stars 86 forks source link

Random sound pitch for arbitrary sample rate #512

Closed FozzeY closed 1 month ago

FozzeY commented 1 month ago

This fixes an oversight where the sound pitch to stepping lookup table did not account for different sample rates of the sounds, which resulted in the effect not working properly at higher sample rates.

fabiangreffrath commented 1 month ago

Fixed differently in PrBoom+:

https://github.com/coelckers/prboom-plus/commit/02eeb49dbcad7042d6ac572f2d04f1b1b090acee

FozzeY commented 1 month ago

Oh wow, I didn't think to check PrBoom+ for that. It does look a lot better.

kraflab commented 1 month ago

Thanks 👍