search

kraflab / dsda-doom

This is a successor of prboom+ with extra tooling for demo recording and playback, with a focus on speedrunning and quality of life.
341 stars 86 forks source link

Crash triggered by libmad-0.dll #526

Open nobleflame opened 3 weeks ago

nobleflame commented 3 weeks ago

Had a couple of crashes with the latest version of DSDA DOOM. Here is the crash log from Event Viewer:

Faulting application name: dsda-doom.exe, version: 0.0.0.0, time stamp: 0x671ba5e5 Faulting module name: libmad-0.dll, version: 0.0.0.0, time stamp: 0x657ff460 Exception code: 0xc0000005 Fault offset: 0x0000000000002a6e Faulting process id: 0x0x95C Faulting application start time: 0x0x1DB27CAEB96BBE6 Faulting application path: D:\Games\DOOM\DSDA\dsda-doom.exe Faulting module path: D:\Games\DOOM\DSDA\libmad-0.dll Report Id: cb0087b5-4939-4932-9331-97c465d7d7fd Faulting package full name: Faulting package-relative application ID:

rfomin commented 3 weeks ago

What WAD are you running? Could you try creating a new clean folder for DSDA-Doom?

nobleflame commented 3 weeks ago

Will do. It’s happened twice now with Formless Mother: https://www.doomworld.com/forum/topic/148914-formless-mother-mbf21-rc2/

I’ll try a fresh install and report back if I get more crashes.

rfomin commented 3 weeks ago

I've tried both WADs, no crashes for me so far. Also, "Sleepwalking" doesn't seem to have any MP3 music (libmad-0.dll is the MP3 library).

nobleflame commented 3 weeks ago

Interesting, thanks for testing. On my fresh install it hasn't crashed yet either. Put it down to user erorr. I'll close this. Thanks again for your time.

nobleflame commented 3 weeks ago

@rfomin

Had the same crash again today. This was with the Formless Mother wad. https://www.doomworld.com/forum/topic/148914-formless-mother-mbf21-rc2/ Worth noting that Formless Mother does indeed use MP3 files for music.

Here's the crash reports below:

Event viewer:

Faulting application name: dsda-doom.exe, version: 0.0.0.0, time stamp: 0x671ba5e5 Faulting module name: libmad-0.dll, version: 0.0.0.0, time stamp: 0x657ff460 Exception code: 0xc0000005 Fault offset: 0x0000000000002a6e Faulting process id: 0x0x2998 Faulting application start time: 0x0x1DB2C4E1982AFBF Faulting application path: D:\Games\DOOM\DSDA\dsda-doom.exe Faulting module path: D:\Games\DOOM\DSDA\libmad-0.dll Report Id: bc6d9866-504e-4c1b-b6ec-1c9967784b3e Faulting package full name: Faulting package-relative application ID:

And DSDA console:

dsda-doom v0.28.2 (https://github.com/kraflab/dsda-doom/)

dsda-doom is released under the GNU General Public license v2.0. You are welcome to redistribute it under certain conditions. It comes with ABSOLUTELY NO WARRANTY. See the file COPYING for details.

Playing: DOOM 2: Hell on Earth

adding D:/Games/DOOM/DSDA/doom2.wad

adding D:\Games\DOOM\DSDA/dsda-doom.wad

adding D:\Games\DOOM\DSDA\wads\D2SPFX20.WAD

adding D:\Games\DOOM\DSDA\wads\Formless Mother\Formless.wad

Loading DEH lump from D:\Games\DOOM\DSDA\wads\Formless Mother\Formless.wad

Loading DEH file D:\Games\DOOM\DSDA\wads\D2DEHFIX.DEH

Loading DEH file D:\Games\DOOM\DSDA\wads\doom_colored_blood.deh

Using data file directory: D:/Games/DOOM/DSDA/dsda_doom_data/doom2/d2spfx20/formless

mad_registersong succeed. bitrate 112000 samplerate 48000

Edit: this is with a clean DSDA folder.

fabiangreffrath commented 3 weeks ago

Where does dsda-doom get is libmad.dll from? Debian's package is heavily patched, maybe some of these need to get applied here as well.

https://sources.debian.org/src/libmad/0.15.1b-10.2/debian/patches/

rfomin commented 3 weeks ago

I can't replicate the crash yet.

Where does dsda-doom get is libmad.dll from?

It's from MSYS2.

libmad hasn't been updated in over 20 years. I think we should switch to libsndfile for sounds and music.