kraken-robotics / Kraken-cpp

A tentacle-based pathfinding library for nonholonomic robotic vehicles

MIT License

9 stars 3 forks source link

Closed kay0u closed 6 years ago

kay0u commented 6 years ago

1

PFGimenez commented 6 years ago

operator== is missing (I take care of it)

Hindi commented 6 years ago

There are some magic values in Kinematic::operator==, consider using constants or at least add comments to explain what they mean (why 50 * 50 ?).

PFGimenez commented 6 years ago

After discussion with @Hindi, we decided to restore the default operator== and to introduce a method isSimilarinstead.

Hindi commented 6 years ago

compute_new_orientation should be computeNewOrientation