search

krakjoe / pthreads

Threading for PHP - Share Nothing, Do Everything :)
Other
3.47k stars 501 forks source link

PHP 7.3.0beta1 Windows PECL builds? #889

Open user765567 opened 6 years ago

user765567 commented 6 years ago

Environment

Summary

Where can I download PHP7.3 Windows builds? (or when will they be available?) Thank you!

For reference, it works fine for me on PHP7.2.

Reproducing Code

php -v

Expected Output

No error

Actual Output

The procedure entry point _zend_hash_update@@24 could not be located in the dynamic link library php7ts.dll.

dktapps commented 6 years ago

pthreads doesn't support 7.3.0 beta1 yet.

My1 commented 5 years ago

considering PHP 7.3 is now in GA, any updates to 7.3 support?

tpunt commented 5 years ago

PR #882 takes care of this. Not too sure when exactly it will be completed, though.

sirsnyder commented 5 years ago

@tpunt, @dktapps, I've compiled today php 7.3 with #882 and everything seems fine, all tests passed. Do you have any concerns, otherwise I would merge and release #882 together with #831 within the next one / two days

dktapps commented 5 years ago

@SirSnyder I haven't touched the PR in a few months so I don't know if any other changes might have sneaked in which break pthreads, so test carefully. If it's working well, it's all good to me.

Generally on a PHP version change I start seeing bugs popping up with PocketMine-MP which aren't caught by the unit tests which are hard to reproduce, so I'd like to get test runs done on a proper application before I can say I'm sure it's good.

sirsnyder commented 5 years ago

@dktapps Because all tests passed, your patch is basically ready to merge. The patch must not be perfect, edge cases will always happen and can get fixed in further development. What do you estimate, when could you run some tests on PocketMine-MP?

dktapps commented 5 years ago

If you're happy with it, feel free to go ahead and merge it, but do give it time for the wtfs to start popping up before tagging a release :)

I hope to be able to test PM on 7.3 before the end of the week.

sirsnyder commented 5 years ago

I'm fine to wait another week, if this happens in '18 ;-)

tobiastromm commented 5 years ago

Same error here with Windows Server 2016 + PHP 7.3.1 +pthreads v3.2.0.

sirsnyder commented 5 years ago

pthreads v3.2.0 only supports PHP 7.2. Take master for 7.3

tobiastromm commented 4 years ago

Hi,

I am using master and it's ok with Windows 7 and Server 2008 R2 (php 7.3).

Using it on Windows Server 2019 Standard x64, give me the error below:

"PHP Warning: PHP Startup: Unable to load dynamic library 'php_pthreads' (tried: C:\php\ext\php_pthreads (No foi possvel encontrar o mdulo especificado.), C:\php\ext\php_php_pthreads.dll (No foi possvel encontrar o mdulo especificado.)) in Unknown on line 0"

Can someone fix please?