search

krasserm / streamz

A combinator library for integrating Functional Streams for Scala (FS2), Akka Streams and Apache Camel
Apache License 2.0
282 stars 44 forks source link

Versions update #15

Closed cquiroz closed 8 years ago

cquiroz commented 8 years ago

This PR updates the code to be able to work with Play 2.5.3 and use streams from scalaz-stream 0.8a

I tested this converting a scalaz stream to a source for WebSockets under play

All tests are passing

krasserm commented 8 years ago

@cquiroz thanks you very much for the update. Does anything speak against using the latest Akka 2.4.4?

cquiroz commented 8 years ago

Do you think this could be merged and released?

krasserm commented 8 years ago

Of course I'd like to merge and release, just wanted to know why you didn't upgrade to the latest Akka release (see my previous comment), meanwhile Akka 2.4.6?

cquiroz commented 8 years ago

My use case is with play framework and the latest version used at the time was 2.4.2. I'll be happy to update the port to the very latest akka

krasserm commented 8 years ago

@cquiroz great, and please squash your commits into a single commit, thanks!

cquiroz commented 8 years ago

@krasserm Updated to 2.4.6 as suggested and squashed. I updated scala to 2.11.8 to avoid an eviction warning as akka 2.4.6 depends on scala 2.11.8. All tests are passing

krasserm commented 8 years ago

Thanks a lot @cquiroz. Will merge and release later this week.