search

kratiahuja / broccoli-tslinter

Broccoli Plugin to run linter on typescript files. Uses tslint internally.
MIT License
9 stars 6 forks source link

Handle `extends` option correctly in when calling `tslint` #12

Closed kratiahuja closed 7 years ago

kratiahuja commented 7 years ago

Before calling the tslint linter, we need to call findConfiguration in order for extends to be resolved.

Addresses: https://github.com/kratiahuja/broccoli-tslinter/issues/9 cc: @turbo87

kratiahuja commented 7 years ago

@turbo87: can you please try this in your project? I want to make sure this works correctly for you.

Turbo87 commented 7 years ago

@kratiahuja seems to work! 👍

one issue I noticed though is that when I change the tslint.json file the tests are apparently not updated, but that seems to be a different issue and unrelated to fixing the extends feature.

kratiahuja commented 7 years ago

@Turbo87 yeah i am aware of that issue. I need to track that down. Will probably do it this weekend.

I'll merge and release this today. Thanks for your help here!

kratiahuja commented 7 years ago

broccoli-tslinter@2.0.1 is released!