search

kratiahuja / broccoli-tslinter

Broccoli Plugin to run linter on typescript files. Uses tslint internally.
MIT License
9 stars 6 forks source link

does not appear persistent #5

Open stefanpenner opened 8 years ago

stefanpenner commented 8 years ago

The TS linter appears sufficiently costly, that enabling the persistent mode would be a nice startup improvement.

kratiahuja commented 8 years ago

@stefanpenner Do you mean using broccoli-persistent-filter? I thought I am extending from that. I am still new to broccoli stuff and this was my first broccoli plugin so maybe I am not understanding this issue completely :-)

stefanpenner commented 8 years ago

@kratiahuja ya, its confusing (most likely the author of persistent-filter itself fault)

TL;DR persistent-filter provides a more efficient and stable filter subclass, but the persistent part is opt-in. This is because cache keys are hard, and require extra thought.

https://github.com/stefanpenner/broccoli-persistent-filter#persistent-cache may help, let me know if it does not I would love some input on how to improve the docs.

kratiahuja commented 8 years ago

Aah ok, this makes sense now. I didn't realize it was an opt-in. I'll read through the docs. I'll look into this sometime this week :) . Thank you @stefanpenner !