search

kripken / box2d.js

Port of Box2D to JavaScript using Emscripten
1.32k stars 198 forks source link

WebIDL bindings. #58

Closed mlogan closed 10 years ago

mlogan commented 10 years ago

We can't merge this until emscripten 1.23.0, as this depends on a lot of new features in the IDL binder.

Closes https://github.com/kripken/box2d.js/issues/56, https://github.com/kripken/box2d.js/issues/47, and likely a lot of others.

Removes the need for customizeVTable, but sadly breaks any existing code that uses it. That's progress.

After this gets merged, it should be very easy to upgrade to the latest Box2D version.

Still TODO: Bindings for array attributes. See: https://github.com/kripken/emscripten/pull/2686

kripken commented 10 years ago

Nice work! I'm happy to merge this regardless of emscripten merge status, we can tell people that are building to use emscripten incoming.

Btw, why all the file mode changes?

mlogan commented 10 years ago

The file mode changes are because the modes that were there previously were strange - (many files had execute bits set that didn't need it). The new modes are just the ones that come out of https://code.google.com/p/box2d/downloads/detail?name=Box2D_v2.2.1.zip as-is.

I can revert the mode changes if you'd prefer, it just seemed like the earlier ones were in error.

kripken commented 10 years ago

Sounds good then.