search

krishauser / Klampt

Kris' Locomotion and Manipulation Planning Toolkit
BSD 3-Clause "New" or "Revised" License
378 stars 96 forks source link

Regression: Geometry3D groups cannot be displayed properly #83

Closed smeng9 closed 3 years ago

smeng9 commented 3 years ago

After bumping klampt installed from pypi from 0.8.3 to 0.8.5, Geometry3D groups cannot be displayed in visualization. That causes meshes disappearing on TRINA GUI.

I have adapted the examples at the bottom of https://github.com/krishauser/Klampt/blob/master/Python/docs/source/Manual-Modeling.rst into the following zip. The following code cannot display a shelf on 0.8.5, but can display a shelf on 0.8.3. If we display Geometry3D one by one manually, they can still be displayed. However after calling setGroup() it cannot display anything in that group.

geometry3d_regression.zip

Additionally there seems a typo in the provided sample code https://github.com/krishauser/Klampt/blob/master/Python/docs/source/Manual-Modeling.rst w = WorldModel() probably should be changed to world = WorldModel()

smeng9 commented 3 years ago

The Geometry3D group visualization issues seems is fixed. Closing this now. Thank you.

However the visualized shelf seems have a diagonal line at each side of the surface compared to before. Is this due to the new rendering features?

krishauser commented 3 years ago

Can you show a screenshot?

smeng9 commented 3 years ago

Sure, before and after comparison.

before after

krishauser commented 3 years ago

Does it go away if you call

appearance.setDraw(Appearance.EDGES,False)?

On Dec 16, 2020, at 3:59 PM, smeng9 notifications@github.com wrote:

 Reopened #83.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

smeng9 commented 3 years ago

Setting the edges to False seems have no effect on rendering.

krishauser commented 3 years ago

OK, it should be fixed with the latest commit to KrisLibrary.