search

kriskowal / gtor

A General Theory of Reactivity
MIT License
3.03k stars 109 forks source link

fix #32: the generator code example now works as described #43

Closed Gahen closed 6 years ago

Gahen commented 6 years ago

It should fix #32 without changing so much the spirit and complexity of the example

kriskowal commented 6 years ago

Thank you for providing this change. Upon reflecting on your suggestion, I’ve realized that we can change the narrative to match the behavior and still provide the learning objective from the section, while maintaining the clearest possible example.

I decided to use log messages to make the flow more clear. I must confess, the mistake you’re fixing stems from my incorrectly visualizing the flow.

For your review: https://github.com/kriskowal/gtor/pull/44

Gahen commented 6 years ago

Great work, I'm glad that the error got fixed and we still have a good narrative about it, that was the hardest part =).