search

krisselden / ember-macro-benchmark

Benchmark recording of an ember app with running with 2 versions of Ember.
25 stars 9 forks source link

use `controlName` and `experimentName` from config #19

Closed bekzod closed 7 years ago

bekzod commented 7 years ago

not sure if this is desired feature :P, also ignoring results folder

bekzod commented 7 years ago

how to generate phases.csv samples.csv gc.csv files ?

rwjblue commented 7 years ago

Seems neat!

@krisselden / @rondale-sc - Thoughts?

@bekzod - I think this needs a rebase now that I merged the documentation PR.

bekzod commented 7 years ago

@rwjblue R file still expects phases.csv samples.csv gc.csv should I revert this https://github.com/krisselden/ember-macro-benchmark/commit/6f7b66d2c8f1032e0721065b6f8e7c217644f0ca ?

bekzod commented 7 years ago

I think this is superseded by https://github.com/krisselden/ember-macro-benchmark/pull/16/files

krisselden commented 7 years ago

@rondale-sc was working on making this use the scripts now packaged with chrome-tracing.

bekzod commented 7 years ago

closing this https://github.com/krisselden/ember-macro-benchmark/pull/16/files seems to address this already

rwjblue commented 7 years ago

Yeah. Sorry about that y'all.