krober10nd / SeismicMesh

2D/3D serial and parallel triangular mesh generation tool for finite element methods.
https://seismicmesh.readthedocs.io/
GNU General Public License v3.0
126 stars 32 forks source link

simplify api + improve minimum cell quality in 2d #144

Closed krober10nd closed 3 years ago

krober10nd commented 3 years ago

141

krober10nd commented 3 years ago

@jorgensd I also added a delete_low_quality_boundary_cell step at the very end before exiting generate_mesh.

The order of the delete boundary cells can be fiddled with. I suspect there's probably an optimal order but as it is in now, it's a significant improvement in minimum cell quality than what it was.

Here is the BP2004 benchmark ran again with the new changes benchmark_bp2004

and here is the disk benchmark (a 40-50 % improvement in minimum cell qualities).

disk

krober10nd commented 3 years ago

It will be interesting to see how this changes @nschloe benchmarks in meshgen_comparison.

krober10nd commented 3 years ago

okay, after rearranging the location of delete_boundary_entities around the laplacian smooth, min. qualities appear more stable.

for the BP2004 model. benchmark_bp2004_v2

krober10nd commented 3 years ago

143