search

krober10nd / SeismicMesh

2D/3D serial and parallel triangular mesh generation tool for finite element methods.
https://seismicmesh.readthedocs.io/
GNU General Public License v3.0
126 stars 32 forks source link

generate_mesh() in README.md example needs h0=100 #160

Closed HamishB closed 3 years ago

HamishB commented 3 years ago

generate_mesh() listed in the example fails with a missing 'h0'. Adding ", h0=100" did the trick.

krober10nd commented 3 years ago

Which example? There's 13. And which version of SeismicMesh are you on?

print(__SeismicMesh.__version__)

The usage of h0 (hmin) in the call to generate-mesh was not required for some time now. See the changelog at the end of the README for when that happened. generate_mesh gets h0 from the sizing function class. All the examples on the README use a SizeFunction class and each example on the README is unit tested each commit.

HamishB commented 3 years ago

BP2004 example, par3d branch git-pulled yesterday.

HamishB commented 3 years ago

or maybe if it's picking up the pip'd version, SeismicMesh-3.1.31

krober10nd commented 3 years ago

Ah okay. The default branch is master for some time now. Did you install via pip or from source?

krober10nd commented 3 years ago

and fyi, all the examples on the README are always going to be valid for the last master HEAD.