search

krosenvold / bgit

Plugin providing git support to Atlassian Bamboo
http://github.com/krosenvold/bgit
Other
31 stars 6 forks source link

File.pathSeparator not valid #8

Open jamesladd opened 14 years ago

jamesladd commented 14 years ago

You might find that in file bgit/src/main/java/edu/nyu/cs/javagit/api/JavaGitConfiguration.java on line 83 you want to use "File.separator" rather than pathSeparator

Also on line 139 as well.

It would be nice if you checked for OS and suffixed Git with nothing or .exe

krosenvold commented 14 years ago

Fixed separator issue. Does NICE have any practical implications ?

krosenvold commented 14 years ago

To re-quote: I have no environment for testing windows on a regular basis and would rather not change the .exe part if it doesn't matter. Does it matter ?