kruize / autotune

Autonomous Performance Tuning for Kubernetes!
Apache License 2.0
165 stars 54 forks source link

Refactor Bulk Job Manager to call createExperiments API #1337

Closed khansaad closed 1 month ago

khansaad commented 1 month ago

Description

This PR refactors the bulk job manager to call the createExperiments API for experiment creation replacing redundant code for adding new experiments.

Fixes # (issue)

Type of change

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

Test Configuration

Checklist :dart:

Additional information

Test image: quay.io/khansaad/autotune_operator:bulk-api-fix

khansaad commented 1 month ago

Local monitoring demo works fine now. Bulk demo is failing due to a datasource issue, fixing that.

dinogun commented 1 month ago

@khansaad Would be good if you can rebase this on top of PR #1332

dinogun commented 1 month ago

@khansaad Please rebase on top of mvp_demo as PR #1332 is now merged

dinogun commented 1 month ago

@khansaad Please update the local_monitoring and bulk API test results here, thanks

khansaad commented 1 month ago

@khansaad Please update the local_monitoring and bulk API test results here, thanks

LM Demo Response: https://privatebin.corp.redhat.com/?21d205a6bba724fd#2sFryeAfKVW9zf5m2a4NjNU1USJxwhEMEqPDn4ubcVnA

Bulk Demo Response: https://privatebin.corp.redhat.com/?2ec351fb611c5918#HSo15gBk1JfpcA2B1LiCTwAKUsSvEznQK58kFWFX7MKE

Jenkins run for the same : https://ci.app-svc-perf.corp.redhat.com/job/ExternalTeams/job/Autotune/job/kruize_local_release_tests/4/

kruize_20241011:19:59:15.zip

khansaad commented 1 month ago

Added the demo results and the local monitoring test results