search

ksiazkowicz / lightbulb

Open-source XMPP client for Symbian, written using QML and QtQuick libraries.
GNU General Public License v3.0
22 stars 5 forks source link

Reduce amount of direct calls to xmppConnectivity.client to minimum #50

Closed ksiazkowicz closed 10 years ago

ksiazkowicz commented 10 years ago

The code is pretty full of xmppConnectivity.client calls which are remains of the old implementation. It calls currently selected accounts MyXmppClient instance.

There are many places when this is an invalid way of doing things and also causes some dumb bugs, for example notifications code. When you receive typing event on the account different from currently selected, notification won't appear.

The worst thing is, even reconnection dialog calls the client this way. This is a critical bug I accidentally introduced and must be fixed ASAP. Some work was already done in Fluorescent branch regarding this issue but it's not possible to merge it back to 0.3.

ksiazkowicz commented 10 years ago

Critical parts sorted out, pushed to 0.4.

ksiazkowicz commented 10 years ago

New conversation page no longer calls xmppConnectivity.client directly.

ksiazkowicz commented 10 years ago

Done.