ktomk / pipelines

Pipelines - Run Bitbucket Pipelines Wherever They Dock
https://ktomk.github.io/pipelines/
GNU Affero General Public License v3.0
109 stars 10 forks source link

coverage-checker.php deprecated notice #24

Closed bkdotcom closed 1 year ago

bkdotcom commented 1 year ago

https://github.com/ktomk/pipelines/blob/3e67dce08f89e038cbef7088ec1002aab93faf6a/lib/build/coverage-checker.php#L53

PHP Deprecated: Using ${var} in strings is deprecated, use {$var} instead in .../coverage-checker.php on line 53

needs to be either
$xml->xpath('.//metrics/@' . $s . 'elements')
or
$xml->xpath(".//metrics/@{$s}elements")

ktomk commented 1 year ago

Thanks for reporting, version 0.0.70 has this now in (+ a couple of other places), see change log (0.0.70).

What follows is only for reference, I close the issue, feel free to re-open if there is anything about it.


PHP 8.2 Deprecate ${} string interpolation (Created on 2021-03-13)