kubaska / twitch-fox

(Fork) Quickly browse Twitch. Receive notifications for followed channels. Many customizable features.
16 stars 1 forks source link

Hi! Some issues #1

Open Rex000 opened 2 years ago

Rex000 commented 2 years ago

Hey @kubaska,

Haven't heard from you in a while nor there was any new updates for TF. I thought you didn't read my last message so I thought about posting here.

A few more issues that I just came across:

Glad to hear that the game data can be displayed using GQL api. As I've stated before too that it's really hard to click on every single game thumbnail to check if there are any live streams for it. It's a shame that they made the api less useful than it used to be instead of the other way around. I really hope the GQL api works as it would be a very useful feature to have. I'm eagerly waiting for it.

Thanks!

kubaska commented 2 years ago

Hello @Rex000, Sorry for my really late reply, and about not replying at all on your other comment. I was busy with work and life stuff and completely forgot about it.

About your reported issues:

About GQL: I started reading about it and have mixed feelings. For example, one of the reasons Chatterino is not using it is that they don't want to risk a lawsuit. Though, for an extension this small it would probably be fine to implement it as a "proof of concept". The bigger issue is that when I tried using it in browser there was no way to send a request without cookies - this means if you're logged in to Twitch (in browser, not TF), they can connect request with your account, and apparently there is a risk that you can get banned for that. So, as you see it's not that easy as just implementing it. Of course, there are ways to mitigate that, but it's falling outside the scope of a browser extension.

I'll see what can I do about it in the coming weeks. Thanks for using Twitch Fox.

Rex000 commented 2 years ago

Hey @kubaska,

Wow, I can't believe how much they downgraded their api. First we couldn't have the game data, and now we can't even have the profile pics.

Something off the top of my head about profile pics: Is it possible that we could make refreshing them a manual thing? Like for instance have a "Refresh all profile pics" button in the add-on options that only updates all of them if the user manually clicks on it? That would be enough I guess. Just a thought.

But regardless, thanks for the awesome work!

Rex000 commented 2 years ago

v5.1.3 just got installed and I immediately noticed that the refresh button is still not removing offline streams from the list. The empty thumbnails remain there forever no matter how many times you refresh. I refreshed even after an hour and they were still not removed.

Games tab Screenshot - 06_09_2022 , 2_43_14 am

Streams tab Screenshot - 06_09_2022 , 4_04_43 am

kubaska commented 2 years ago

Just to confirm, are you sure you're refreshing with button from the addon, the one to the right of search bar and to the left of your Twitch avatar, and not the browser one? I just tried refreshing after a while and it works just fine for me.

Rex000 commented 2 years ago

Ah, you're right. I was indeed doing F5 or clicking the browser refresh button because that's what I do in my followed streams tab in extended view, and doing so actually works. So naturally I was doing the same thing in other tabs too, but apparently that's not the case with them.

Though for consistency and convenience sake, I think it would be a good thing to have the F5/browser refresh button ability across all tabs, in extended view.

Rex000 commented 1 year ago

Hi, just noticed an inconsistency in the add-on's refresh button. It does remove the empty thumbnails as stated above but it often doesn't update the thumbnail images. Only clicking the browser's refresh button updates them.

kubaska commented 1 year ago

Hi Rex, I've done some testing on this, and they're refresh fine for me. Stream previews are updated every so often, and Twitch servers tell your browser to cache them for 5 minutes. So it seems that in the worst case scenario thumbnails will not change for ~10 minutes? But I can confirm refresh button works. I am rerendering all stream cards after all.

Rex000 commented 1 year ago

Yeah it does change the thumbnails if you wait that long. What I don't understand though is why it updates them once browser refresh is clicked, even if it's been under a minute?

Couple more things. Firefox recently updated and the streamer notification popup seems to now be receiving on Windows side instead of browser side. At least that's the case for Windows 10. This is ok, but now when you click on the popup it randomly sometimes opens up the stream while other times it doesn't. I have my setting "After clicking notification" set to "Stream in new tab".

Moreover the notification popup doesn't appear for every stream that comes online. Seems like it randomly works.