search

kubecost / cost-analyzer-helm-chart

Kubecost helm chart
http://kubecost.com/install
Apache License 2.0
475 stars 415 forks source link

Deploy sigv4 sidecar for Thanos queries #1321

Closed kirbsauce closed 8 months ago

kirbsauce commented 2 years ago

Ideally, would like to have top-level “values” for the AMP workspace that would create a sigv4 sidecar for Thanos queries and set the remote_write values for primary and secondary clusters. As a workaround. This would eliminate the need to run a sigv4 proxy as a workaround.

┆Issue is synchronized with this Jira Task by Unito

dwbrown2 commented 2 years ago

@kirbsauce thanks for reporting. any change you can share what problem this is solving or why running a sigv4 proxy is needed? I thought thanos supported a signature_version2: false flag.

kirbsauce commented 2 years ago

@AjayTripathy can confirm, but I believe sigv4 is needed to make remote-write API calls to AMP. The diagram in this article seems to note the need for a proxy or sidecar with older versions of prometheus. https://aws.amazon.com/blogs/opensource/prometheus-2-26-0-adds-aws-signature-version-4-support/ image

AjayTripathy commented 2 years ago

The sigv4 proxy is needed for reads against AMP. I believe remote write to AMP is already supported internally within prometheus.

kirbsauce commented 2 years ago

thanks @AjayTripathy !

github-actions[bot] commented 8 months ago

This issue has been marked as stale because it has been open for 360 days with no activity. Please remove the stale label or comment or this issue will be closed in 5 days.

github-actions[bot] commented 8 months ago

This issue was closed because it has been inactive for 365 days with no activity.