search

kubecost / features-bugs

A public repository for filing of Kubecost feature requests and bugs. Please read the issue guidelines before filing an issue here.
0 stars 0 forks source link

Consistency in the Allocation API values #86

Closed thomasvn closed 6 months ago

thomasvn commented 1 year ago

What problem are you trying to solve? It is difficult to build automation using the output of the Allocation API when the values of certain keys are not consistent in format. Specifically, providerID. Below are some examples of all variants of providerID you can find for Azure and AWS.

# Azure
aks-pool0-10530930-vmss000000
azure:///subscriptions/REDACTED/resourceGroups/mc_prod-az-eastus-REDACTED/providers/Microsoft.Compute/virtualMachineScaleSets/aks-pool2az2-21554833-vmss/virtualMachines/17

# AWS
i-00a37f3379d9d5f8b
ip-10-250-39-203.ec2.internal
ip-172-21-30-253.us-west-1.compute.internal

More examples can be found in this Slack Thread. Reach out to me if access is needed.

Describe the solution you'd like Consistency in which providerID format is outputted by the Allocation API.

Describe alternatives you've considered Currently, my automation needs to handle all variants of providerID.

How would users interact with this feature? Via the Allocations API.

kwombach12 commented 1 year ago

Thanks @thomasvn. Consistency here makes a lot of sense.

mmurph3 commented 1 year ago

@kwombach12 @cliffcolvin any updates on this?

kwombach12 commented 1 year ago

@mmurph3 we have not started work on this yet. We are focused on scalability and fixing bugs in 105 & 106

chipzoller commented 6 months ago

Transferred to features-bugs.

@thomasvn, any idea if this is still an issue? If not, would you close?

thomasvn commented 6 months ago

I haven't validated whether this is still an issue in Kubecost 2.x. Closing for now.