kubeflow / code-intelligence

ML-Powered Developer Tools, using Kubeflow
https://medium.com/kubeflow/reducing-maintainer-toil-on-kubeflow-with-github-actions-and-machine-learning-f8568374daa1?source=friends_link&sk=ac77444f00c230e7d787edbfb0081918
MIT License
55 stars 21 forks source link

[labelbot] Not correctly applying label alias defined in org level config #139

Closed jlewi closed 4 years ago

jlewi commented 4 years ago

Here's an example issue: https://github.com/kubeflow/gcp-blueprints/issues/6

LabelBot applied the label "feature" rather than mapping it to "kind/feature".

There is both a repo level config: https://github.com/kubeflow/gcp-blueprints/blob/master/.github/workflows/issue_label_bot.yaml

And an org level config https://github.com/kubeflow/code-intelligence/blob/master/.github/issue_label_bot.yaml

The code to apply the alias is here https://github.com/kubeflow/code-intelligence/blob/17c86084e5c6d834455d89e6fca9e3223595faa3/py/label_microservice/worker.py#L339

I recently updated it to take into account the org wide config.

issue-label-bot[bot] commented 4 years ago

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.71

Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! Links: app homepage, dashboard and code for this bot.

kf-label-bot-dev[bot] commented 4 years ago

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

jlewi commented 4 years ago

Logs indicate there is no repo specific config. https://github.com/kubeflow/code-intelligence/blob/17c86084e5c6d834455d89e6fca9e3223595faa3/py/label_microservice/worker.py#L271

e.g for issue https://github.com/kubeflow/kfserving/issues/810

jlewi commented 4 years ago

Logs show 404s

Exception occured getting .github/issue_label_bot.yaml: 404 Not Found
jlewi commented 4 years ago

I suspect this might be because the issue label bot isn't installed on the .github repo. So I added it to that repo lets see if it starts to work.

jlewi commented 4 years ago

This is fixed by installing the bot on ".github" repo. Here's an issue showing we applied the appropriate alias for "feature" to /kind/feature https://github.com/kubeflow/gcp-blueprints/issues/9