kubeflow / notebooks

Kubeflow Notebooks lets you run web-based development environments on your Kubernetes cluster by running them inside Pods.
Apache License 2.0
18 stars 22 forks source link

Notebook Listing Page - Resources #119

Open ronaldpetty opened 9 months ago

ronaldpetty commented 9 months ago

/kind feature

Why you need this feature:

The listed resource are misleading (a little). When creating a notebook, the "minimum" is actually both minimum and maximum because its listed as request and limits just the same (for notebook resource). I think a few items regarding resources could be useful to know what is be being used by notebooks (versus using other tools to figure it out).

Describe the solution you'd like:

Also related to resource tracking. If a notebook resource becomes a pod resource, maybe tie the names a little more.

~$ kubectl get notebooks.kubeflow.org -A
NAMESPACE   NAME    AGE
team-1      test1   11m

~$ kubectl get pods -n team-1
NAME                                               READY   STATUS    RESTARTS      AGE
ml-pipeline-ui-artifact-789d54d746-qf4r6           2/2     Running   2 (25h ago)   46h
ml-pipeline-visualizationserver-6659778c46-nw5g9   2/2     Running   2 (25h ago)   46h
test1-0                                            2/2     Running   0             10m

The test1-0 pod I believe is the notebook, but the name format is different and unclear how it ties back to that one notebook. (also don't know if the pipelines are involved here, so same issue if they are, labels don't relate them clearly to me).

Keep up the good work!

ronaldpetty commented 9 months ago

Related to last part on names/labels. I noticed in the "EVENTS" of the notebook, it didn't list the pods that were from the stateful set. I would think the entire chain from notebook->statefulset->pod<-pvc would be a good list. I was looking for where the PVCs where actually mounted (obvious now, but unclear on first read of guide as it doesn't mention mount point).

image
andreyvelich commented 2 weeks ago

/transfer notebooks

google-oss-prow[bot] commented 2 weeks ago

@ronaldpetty: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubeflow/notebooks/issues/119): >/kind feature > >**Why you need this feature:** > >The listed resource are misleading (a little). When creating a notebook, the "minimum" is actually both minimum and maximum because its listed as request and limits just the same (for notebook resource). I think a few items regarding resources could be useful to know what is be being used by notebooks (versus using other tools to figure it out). > >**Describe the solution you'd like:** > >* Add ability to set limit and request separately for notebooks >* From a k8s "resources" view in notebook resources - show both limit and request >* Add volume listing to notebooks (workspace and data) >* add summation of resources per notebook and per all notebooks (I assume for that namespace) > >Also related to resource tracking. If a notebook resource becomes a pod resource, maybe tie the names a little more. > >``` >~$ kubectl get notebooks.kubeflow.org -A >NAMESPACE NAME AGE >team-1 test1 11m > >~$ kubectl get pods -n team-1 >NAME READY STATUS RESTARTS AGE >ml-pipeline-ui-artifact-789d54d746-qf4r6 2/2 Running 2 (25h ago) 46h >ml-pipeline-visualizationserver-6659778c46-nw5g9 2/2 Running 2 (25h ago) 46h >test1-0 2/2 Running 0 10m >``` > >The test1-0 pod I believe is the notebook, but the name format is different and unclear how it ties back to that one notebook. (also don't know if the pipelines are involved here, so same issue if they are, labels don't relate them clearly to me). > >Keep up the good work! Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.