kubeflow / notebooks

Kubeflow Notebooks lets you run web-based development environments on your Kubernetes cluster by running them inside Pods.
Apache License 2.0
18 stars 22 forks source link

Add `kubeflow-katib` and `kserve` packages to default notebook images #122

Open thesuperzapper opened 5 months ago

thesuperzapper commented 5 months ago

/kind feature

Currently we don't include the kubeflow-katib and kserve pip packages in the default notebooks. However, we do include the kfp package in the -full suffixed images, for example jupyter-pytorch-cuda-full.

Currently we are blocked by the following upstream issues because kfp has conflicting version dependencies with these packages:

andreyvelich commented 5 months ago

Thanks for creating this @thesuperzapper . kubeflow-katib should be unblocked now since @tenzen-y updated the protobuf version in this PR: https://github.com/kubeflow/katib/pull/2358 The latest version is kubeflow-katib==0.17.0rc1

Also, we might want to include kubeflow-training SDK to the Kubeflow Notebooks as well: https://pypi.org/project/kubeflow-training/

andreyvelich commented 2 weeks ago

/transfer notebooks

google-oss-prow[bot] commented 2 weeks ago

@thesuperzapper: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubeflow/notebooks/issues/122): >/kind feature > >Currently we don't include the [`kubeflow-katib`](https://pypi.org/project/kubeflow-katib/) and [`kserve`](https://pypi.org/project/kserve/) pip packages in the default notebooks. However, we do include the `kfp` package in the `-full` suffixed images, for example [`jupyter-pytorch-cuda-full`](https://github.com/kubeflow/kubeflow/blob/v1.9.0-rc.0/components/example-notebook-servers/jupyter-pytorch-cuda-full/requirements.txt#L2). > >Currently we are __blocked__ by the following upstream issues because `kfp` has conflicting version dependencies with these packages: > >- `kubeflow-katib`: https://github.com/kubeflow/katib/issues/2346 >- `kserve`: https://github.com/kserve/kserve/issues/3730 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.