kubeflow / notebooks

Kubeflow Notebooks lets you run web-based development environments on your Kubernetes cluster by running them inside Pods.
Apache License 2.0
18 stars 22 forks source link

feat(ws): initial commit for controller #5

Closed jiridanek closed 6 months ago

jiridanek commented 6 months ago
cd workspaces/controller
go mod init github.com/kubeflow/notebooks/workspaces/controller
kubebuilder init \
    --plugins=go/v4 \
    --domain=kubeflow.org \
    --project-name=workspace-controller \
    --repo=github.com/kubeflow/notebooks/workspaces/controller
kubebuilder create api --version v1beta1 --kind Workspace
kubebuilder create api --version v1beta1 --kind WorkspaceKind
make manifests

TODO:

maybe something else from https://docs.google.com/document/d/1SiWLah-U07hAc47sSsoI8-NkbkLnHl1YVzxw193QUKE/edit#heading=h.naudedl8te2q

thesuperzapper commented 6 months ago

@jiridanek I have made a new branch, which we can develop in (rather than main), please make your PR into: https://github.com/kubeflow/notebooks/tree/notebooks-v2

google-oss-prow[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubeflow/notebooks/blob/notebooks-v2/OWNERS)~~ [thesuperzapper] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
thesuperzapper commented 6 months ago

/lgtm