search

kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.63k stars 1.63k forks source link

feat(backend): add configurable S3 path style support #11246

Closed ntny closed 2 months ago

ntny commented 2 months ago

Description of your changes: Resolve: #10814

This MR introduces the ability to configure the S3 path style Currently it is hardcoded here as pathStyle 'PathStyle' will be the default setting

Checklist:

google-oss-prow[bot] commented 2 months ago

Hi @ntny. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
hbelmiro commented 2 months ago

/ok-to-test /rerun-all

ntny commented 2 months ago

/rerun-all

HumairAK commented 2 months ago

/lgtm /approve

Thanks @ntny !

Can you also update the documentation here: https://github.com/kubeflow/website/blob/master/content/en/docs/components/pipelines/operator-guides/configure-object-store.md

Doesn't need to be elaborate, updating the examples to indicate this optional field exists is sufficient in my opinion.

HumairAK commented 2 months ago

/approve

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[backend/OWNERS](https://github.com/kubeflow/pipelines/blob/master/backend/OWNERS)~~ [HumairAK] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment