Closed VaniHaripriya closed 1 month ago
Hi @VaniHaripriya. Thanks for your PR.
I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/rerun-all
/ok-to-test
(not sure if that label is needed for /rerun-all to work)
/rerun-all
Resource not accessible by integration (addLabelsToLabelable)
sounds like the GITHUB_TOKEN provided doesn't have proper permissions to add the label (likely needs write
on pull-requests
)
the token's permissions are limited when runnin on PRs
GraphQL: Resource not accessible by integration (addLabelsToLabelable)
we have to be careful here, if we give this workflow the permission to add labels, users will be able to change the workflow and game their way to a merge by adjusting the checks/labels
you can use workflow_run event to put a workflow in main , and run the label add functionality there, this should have access to ${{ secrets.GITHUB_TOKEN }} because it's running from main branch
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hbelmiro
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
Description of your changes:
ci-passed
label once all CI checks have passed.ci-passed
label when the pull request is either synchronized or reopened.PR to update GoogleCloudPlatform/oss-test-infra https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2392
Checklist: