kubeflow / pipelines

Machine Learning Pipelines for Kubeflow
https://www.kubeflow.org/docs/components/pipelines/
Apache License 2.0
3.63k stars 1.63k forks source link

test: Integrate Git Hub Action Results into Tide #11262

Closed VaniHaripriya closed 1 month ago

VaniHaripriya commented 1 month ago

Description of your changes:

PR to update GoogleCloudPlatform/oss-test-infra https://github.com/GoogleCloudPlatform/oss-test-infra/pull/2392

Checklist:

google-oss-prow[bot] commented 1 month ago

Hi @VaniHaripriya. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
VaniHaripriya commented 1 month ago

/rerun-all

gmfrasca commented 1 month ago

/ok-to-test

(not sure if that label is needed for /rerun-all to work)

gmfrasca commented 1 month ago

/rerun-all

gmfrasca commented 1 month ago

Resource not accessible by integration (addLabelsToLabelable)

sounds like the GITHUB_TOKEN provided doesn't have proper permissions to add the label (likely needs write on pull-requests)

HumairAK commented 1 month ago

the token's permissions are limited when runnin on PRs

https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

GraphQL: Resource not accessible by integration (addLabelsToLabelable)

we have to be careful here, if we give this workflow the permission to add labels, users will be able to change the workflow and game their way to a merge by adjusting the checks/labels

you can use workflow_run event to put a workflow in main , and run the label add functionality there, this should have access to ${{ secrets.GITHUB_TOKEN }} because it's running from main branch

google-oss-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[.github/OWNERS](https://github.com/kubeflow/pipelines/blob/master/.github/OWNERS)~~ [hbelmiro] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
hbelmiro commented 1 month ago

/lgtm